there is still a disable bug. i was disabled 2x when it should have been once. i was offline and nobody repaired me.
(names have been changed to protect... the guilty )

15 mins ago From: SHIP2
106 Mineral Units were stolen from you by SHIP2
16 mins ago From: SHIP3
161 Artifact Points were stolen from you by SHIP3
16 mins ago From: SHIP3
Your ship has been disabled by SHIP3!
View Your Ship
16 mins ago From: SHIP2
Your ship has been disabled by SHIP2!
View Your Ship
17 mins ago
SHIP1 attacked you and set off your Krionus Virus Trap!

i was offline and nobody repaired me.

Wait! I recognize those artifacts being stolen!!

I think I see the problem (it's quite an exploit if they intended it). If you hold open the window of another player's ship, that page doesn't refresh until you commit an action to it. This means a player can be disabled by someone else and the attack button on the screen can still be clicked. If attacked after the ship was already disabled it would count as a disable because the attack resulted in zero hull (even though it was already there).

That means, the backend needs to double check that the action (such as attack) is in fact valid (which it is not when a ship is disabled) -- never trust the game client data as they say. The other time which doesn't seem to be the case here is when two attack requests are so close together that the second is executed before the result of the first is completed, in that case it's a database sync issue.

this is not the issue because if someone attacks later you will get a message saying "this ship has already been disabled", so it does check this state.


i disagree, this one is most likely the cause because the action began too close together and the second action was not blocked from executing to wait for the 1st to finish.